Merged
Conversation
This was referenced Sep 16, 2017
|
Hi @blairhudson, it seems your patch fixes #35 also. It runs |
Collaborator
|
Thank you very much for the patch! I'm swamped with other stuff rn and haven't been able to devote much time to this specific wonderful project, but ill happily merge PRs! |
blairhudson
added a commit
to blairhudson/ipynb
that referenced
this pull request
Sep 19, 2017
Contributor
Author
|
Thanks @yuvipanda @ebraminio. Glad to contribute! One more PR to fix the problem @ebraminio mentioned above: #36 😄 |
yuvipanda
added a commit
that referenced
this pull request
Sep 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug interpreting tuple based assignment.
Example:
Previously this would result in the error described in #31. This fix correctly parses tuple based assignments as intended.